[ https://issues.apache.org/jira/browse/HIVE-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015713#comment-14015713 ]
Thejas M Nair commented on HIVE-4629: ------------------------------------- I have added some comments on review board . I think this feature is very useful. A lot of other people have asked for it in the jira as well. But I think we should address the review board comments and comments in this jira first. We should first agree on the public api before committing the patch. The suggestion from Carl about using the FetchResults api for this makes sense. As the use cases for this evolves, I think it the getLog api is likely to start looking more like the FetchResults api. The TFetchResultsReq can have an additional resulttype parameter (OUTPUT vs LOG). Also, the circular in-memory buffer does not gurantee that you get the whole log, it also puts burden on the HS2 memory requirements. I think we should explore using the approach in HIVE-5924 for this instead of an inmemory pool. But I am OK with having such changes as part of follow up jiras, as long as we don't have the in-memory logging enabled by default in this patch. > HS2 should support an API to retrieve query logs > ------------------------------------------------ > > Key: HIVE-4629 > URL: https://issues.apache.org/jira/browse/HIVE-4629 > Project: Hive > Issue Type: Sub-task > Components: HiveServer2 > Reporter: Shreepadma Venugopalan > Assignee: Shreepadma Venugopalan > Attachments: HIVE-4629-no_thrift.1.patch, HIVE-4629.1.patch, > HIVE-4629.2.patch, HIVE-4629.3.patch.txt > > > HiveServer2 should support an API to retrieve query logs. This is > particularly relevant because HiveServer2 supports async execution but > doesn't provide a way to report progress. Providing an API to retrieve query > logs will help report progress to the client. -- This message was sent by Atlassian JIRA (v6.2#6252)