----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19830/#review46006 -----------------------------------------------------------
beeline/src/java/org/apache/hive/beeline/Commands.java <https://reviews.apache.org/r/19830/#comment81167> Should we be returning a "false" at this point since the command failed? itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java <https://reviews.apache.org/r/19830/#comment81168> Is it possible to test a failed command as well? - Swarnim Kulkarni On June 17, 2014, 1:49 a.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19830/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 1:49 a.m.) > > > Review request for hive. > > > Bugs: HIVE-6694 > https://issues.apache.org/jira/browse/HIVE-6694 > > > Repository: hive-git > > > Description > ------- > > Introduce the new requested feature. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java dcdd6f2 > beeline/src/java/org/apache/hive/beeline/Commands.java 94f74d2 > beeline/src/main/resources/BeeLine.properties 697c29a > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 3357414 > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > 4d15e3c > itests/util/pom.xml b38c55b > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 2974327 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 32c2fb0 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 2ce4dbd > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java d2e122d > > Diff: https://reviews.apache.org/r/19830/diff/ > > > Testing > ------- > > New test cases are added. > > > Thanks, > > Xuefu Zhang > >
