[ https://issues.apache.org/jira/browse/HIVE-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036734#comment-14036734 ]
Hive QA commented on HIVE-7094: ------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12650889/HIVE-7094.5.patch {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 5654 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_optimization org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_ctas org.apache.hadoop.hive.ql.exec.tez.TestTezTask.testSubmit {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/506/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/506/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-506/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12650889 > Separate out static/dynamic partitioning code in FileRecordWriterContainer > -------------------------------------------------------------------------- > > Key: HIVE-7094 > URL: https://issues.apache.org/jira/browse/HIVE-7094 > Project: Hive > Issue Type: Sub-task > Components: HCatalog > Reporter: David Chen > Assignee: David Chen > Attachments: HIVE-7094.1.patch, HIVE-7094.3.patch, HIVE-7094.4.patch, > HIVE-7094.5.patch > > > There are two major places in FileRecordWriterContainer that have the {{if > (dynamicPartitioning)}} condition: the constructor and write(). > This is the approach that I am taking: > # Move the DP and SP code into two subclasses: > DynamicFileRecordWriterContainer and StaticFileRecordWriterContainer. > # Make FileRecordWriterContainer an abstract class that contains the common > code for both implementations. For write(), FileRecordWriterContainer will > call an abstract method that will provide the local RecordWriter, > ObjectInspector, SerDe, and OutputJobInfo. -- This message was sent by Atlassian JIRA (v6.2#6252)