[ https://issues.apache.org/jira/browse/HIVE-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14040041#comment-14040041 ]
Hive QA commented on HIVE-7225: ------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12651800/hive-7225.3.patch {color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 5668 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_dynpart_sort_optimization org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_ctas org.apache.hive.hcatalog.pig.TestOrcHCatLoader.testReadDataPrimitiveTypes org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/548/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/548/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-548/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12651800 > Unclosed Statement's in TxnHandler > ---------------------------------- > > Key: HIVE-7225 > URL: https://issues.apache.org/jira/browse/HIVE-7225 > Project: Hive > Issue Type: Bug > Reporter: Ted Yu > Assignee: steve, Oh > Attachments: HIVE-7225.1.patch, hive-7225.3.patch > > > There're several methods in TxnHandler where Statement (local to the method) > is not closed upon return. > Here're a few examples: > In compact(): > {code} > stmt.executeUpdate(s); > LOG.debug("Going to commit"); > dbConn.commit(); > {code} > In showCompact(): > {code} > Statement stmt = dbConn.createStatement(); > String s = "select cq_database, cq_table, cq_partition, cq_state, > cq_type, cq_worker_id, " + > "cq_start, cq_run_as from COMPACTION_QUEUE"; > LOG.debug("Going to execute query <" + s + ">"); > ResultSet rs = stmt.executeQuery(s); > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)