----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23331/ -----------------------------------------------------------
Review request for hive. Bugs: HIVE-5025 https://issues.apache.org/jira/browse/HIVE-5025 Repository: hive-git Description ------- In some cases, column aliases for input argument are very useful to know. But I cannot sure of this in the sense that UDFs should not be dependent to contextual information like column alias. Diffs ----- itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFColumnNameTest.java PRE-CREATION itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFColumnNameTest.java PRE-CREATION itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFColumnNameTest.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java bb5f4f3 ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 792d87f ql/src/java/org/apache/hadoop/hive/ql/exec/UDTFOperator.java afd7bcf ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java d1d866f ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 399f92a ql/src/java/org/apache/hadoop/hive/ql/plan/AggregationDesc.java 17eeae1 ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java f293c43 ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java 4b2c1ad ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDeserializer.java f75bec5 ql/src/java/org/apache/hadoop/hive/ql/plan/UDTFDesc.java 741a0e0 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFEvaluator.java 3bd97b0 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java e3fb558 ql/src/test/queries/clientpositive/udf_col_names.q PRE-CREATION ql/src/test/results/clientpositive/udf_col_names.q.out PRE-CREATION ql/src/test/results/compiler/plan/groupby1.q.xml 1f53052 ql/src/test/results/compiler/plan/groupby2.q.xml f9e1540 ql/src/test/results/compiler/plan/groupby3.q.xml ee32e0e ql/src/test/results/compiler/plan/groupby5.q.xml 7a63fd1 serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 1baf359 Diff: https://reviews.apache.org/r/23331/diff/ Testing ------- Thanks, Navis Ryu