----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23373/#review47527 -----------------------------------------------------------
ql/src/test/queries/clientnegative/authorization_role_grant2.q <https://reviews.apache.org/r/23373/#comment83439> "set role admin;" is needed here The revoke is not succeeding (in q.out) because of that. - Thejas Nair On July 9, 2014, 7:02 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23373/ > ----------------------------------------------------------- > > (Updated July 9, 2014, 7:02 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-6252 > https://issues.apache.org/jira/browse/HIVE-6252 > > > Repository: hive-git > > > Description > ------- > > Parser changes - support REVOKE ADMIN ROLE FOR > New grant_revoke_role() thrift metastore method > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestAuthorizationApiAuthorizer.java > 6b2f28e > metastore/if/hive_metastore.thrift cc802c6 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > acef599 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 664dccd > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > 0c2209b > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 911c997 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e0de0e0 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 5c00aa1 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 5025b83 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4d8e10c > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 250756c > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g f934ac4 > > ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryImpl.java > 419117c > > ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java > 6ede03c > ql/src/test/queries/clientnegative/authorization_role_grant2.q PRE-CREATION > ql/src/test/queries/clientpositive/authorization_role_grant1.q 051bdee > ql/src/test/results/clientnegative/authorization_role_grant2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/authorization_role_grant1.q.out cdbcb26 > > Diff: https://reviews.apache.org/r/23373/diff/ > > > Testing > ------- > > unit tests added > > > Thanks, > > Jason Dere > >
