----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23320/#review47550 -----------------------------------------------------------
One general question I had is with this scheme is, could background threads get same rawStore instance, and thus see concurrency issue? I wasnt sure if foreground threads could fork multiple background threads that run concurrently? metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/23320/#comment83555> Remove tab service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java <https://reviews.apache.org/r/23320/#comment83556> Will it return null if remote mode? If so, we could put checks in the code to skip it, or at least document the method to mention that, as this wouldn't make sense then? - Szehon Ho On July 7, 2014, 8:29 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23320/ > ----------------------------------------------------------- > > (Updated July 7, 2014, 8:29 p.m.) > > > Review request for hive, Sushanth Sowmyan and Thejas Nair. > > > Bugs: HIVE-7353 > https://issues.apache.org/jira/browse/HIVE-7353 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-7353 > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > acef599 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > de54ca1 > > Diff: https://reviews.apache.org/r/23320/diff/ > > > Testing > ------- > > Manual testing using Yourkit. > > > Thanks, > > Vaibhav Gumashta > >
