> On July 12, 2014, 4:54 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 4560 > > <https://reviews.apache.org/r/23421/diff/1/?file=628741#file628741line4560> > > > > Accuracy is for column stats which are stored in PART_COL_STATS tbl in > > metastore. (not simple stats stored in partition properties) Column stats > > become stale after truncate. So, this flag is set to false. > > Ideally, in such cases we should also delete those stats, but setting > > this flag to false is done in line with how we are invalidating column > > stats in case of other alter statements. > > In a separate jira we should drop column statistics in case of alter > > statements (including truncate).
Understood. +1 - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23421/#review47684 ----------------------------------------------------------- On July 11, 2014, 9:55 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23421/ > ----------------------------------------------------------- > > (Updated July 11, 2014, 9:55 p.m.) > > > Review request for hive. > > > Bugs: HIVE-7213 > https://issues.apache.org/jira/browse/HIVE-7213 > > > Repository: hive-git > > > Description > ------- > > invalidate stats when table is truncated > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java bbf89ef > ql/src/test/queries/clientpositive/truncate_table.q 769b10f > ql/src/test/results/clientpositive/truncate_table.q.out 718895c > > Diff: https://reviews.apache.org/r/23421/diff/ > > > Testing > ------- > > added new tests > > > Thanks, > > Ashutosh Chauhan > >
