> On July 18, 2014, 11:42 p.m., Lars Francke wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java, > > line 269 > > <https://reviews.apache.org/r/23387/diff/9/?file=634613#file634613line269> > > > > "final" is not used elsewhere in this file for local variables and I > > think it's true for most of the rest of Hive's code.
That does not mean using final for local variables is wrong. Convention over correctness? Unless there is a strong reason for not declaring variables, not supposed to be modified, as final, I would argue using final is correct. > On July 18, 2014, 11:42 p.m., Lars Francke wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java, > > line 272 > > <https://reviews.apache.org/r/23387/diff/9/?file=634613#file634613line272> > > > > You're accessing fileSchema in the previous line so it's guaranteed to > > not be null here. Not sure if that's a bug and the check needs to happen a > > line earlier? If not this ternary can be removed. Good catch, this got introduced while refactoring a dual ternary statement. > On July 18, 2014, 11:42 p.m., Lars Francke wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java, line 76 > > <https://reviews.apache.org/r/23387/diff/9/?file=634614#file634614line76> > > > > "final" not consistent with Hive codebase Same as above. > On July 18, 2014, 11:42 p.m., Lars Francke wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java, line 82 > > <https://reviews.apache.org/r/23387/diff/9/?file=634614#file634614line82> > > > > .length() == 0 > > > > can be replaced with > > > > .isEmpty() Done. > On July 18, 2014, 11:42 p.m., Lars Francke wrote: > > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java, line 87 > > <https://reviews.apache.org/r/23387/diff/9/?file=634614#file634614line87> > > > > .isEmpty() > > > > and two more times Done. On July 18, 2014, 11:42 p.m., Ashish Singh wrote: > > Only minor comments. Patch looks good. Thanks for this and I'm looking > > forward to have it included. Thanks for the review. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23387/#review48167 ----------------------------------------------------------- On July 17, 2014, 9:10 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23387/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 9:10 p.m.) > > > Review request for hive. > > > Bugs: HIVE-6806 > https://issues.apache.org/jira/browse/HIVE-6806 > > > Repository: hive-git > > > Description > ------- > > HIVE-6806: Native avro support > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/io/AvroStorageFormatDescriptor.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/IOConstants.java > 1bae0a8fee04049f90b16d813ff4c96707b349c8 > > ql/src/main/resources/META-INF/services/org.apache.hadoop.hive.ql.io.StorageFormatDescriptor > a23ff115512da5fe3167835a88d582c427585b8e > ql/src/test/org/apache/hadoop/hive/ql/io/TestStorageFormatDescriptor.java > d53ebc65174d66bfeee25fd2891c69c78f9137ee > ql/src/test/queries/clientpositive/avro_compression_enabled_native.q > PRE-CREATION > ql/src/test/queries/clientpositive/avro_decimal_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_joins_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_partitioned_native.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_schema_evolution_native.q > PRE-CREATION > ql/src/test/results/clientpositive/avro_compression_enabled_native.q.out > PRE-CREATION > ql/src/test/results/clientpositive/avro_decimal_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_joins_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_native.q.out PRE-CREATION > ql/src/test/results/clientpositive/avro_partitioned_native.q.out > PRE-CREATION > ql/src/test/results/clientpositive/avro_schema_evolution_native.q.out > PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java > 0db12437406170686a21b6055d83156fe5d6a55f > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java > 1fe31e0034f8988d03a0c51a90904bb93e7cb157 > serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java > PRE-CREATION > serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23387/diff/ > > > Testing > ------- > > Added qTests and unit tests > > > Thanks, > > Ashish Singh > >
