----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23967/#review48824 -----------------------------------------------------------
Ship it! Ship It! - Ted Xu On July 27, 2014, 5:18 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23967/ > ----------------------------------------------------------- > > (Updated July 27, 2014, 5:18 p.m.) > > > Review request for hive and Ted Xu. > > > Bugs: HIVE-7524 > https://issues.apache.org/jira/browse/HIVE-7524 > > > Repository: hive-git > > > Description > ------- > > Enable auto conversion of SMBjoin in presence of constant propagate > optimization > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java > 6042470 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagate.java > 3c8940f > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java > c1cc9f4 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java > 5f7682e > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java > 2420971 > ql/src/test/results/clientpositive/join_nullsafe.q.out 37b6978 > ql/src/test/results/clientpositive/smb_mapjoin_25.q.out bd289c3 > > Diff: https://reviews.apache.org/r/23967/diff/ > > > Testing > ------- > > smb_mapjoin_25.q used to fail to convert joins to SMBJoins, now it does. > > > Thanks, > > Ashutosh Chauhan > >