[ 
https://issues.apache.org/jira/browse/HIVE-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075979#comment-14075979
 ] 

Lefty Leverenz commented on HIVE-7254:
--------------------------------------

The links didn't break and the text display was changed too.  Sweet.

However, the Hive Developer FAQ page puts a doc link under the heading/question 
"How do I add a new MiniMR test?" -- perhaps that should be changed to "How do 
I add a new MiniDriver test?"  And if that isn't clear enough, the text could 
be expanded from "See MiniDriver Tests" to "See MiniDriver Tests for 
information about adding MiniMR, MiniTez, and Beeline driver tests" (or some 
such).

Similarly, a link on the Home page to the FAQ doc says "add MiniMR test" which 
should propably say "add MiniDriver test" and a link on the umbrella page for 
Developer Docs says "Adding a MiniMR test" so that should be "Adding a 
MiniDriver test" -- right?

Another one:  PreCommit Patch Testing says "Read MiniDriver Tests before adding 
new minimr tests" -- make that "... before adding new miniMR, miniTez, or 
Beeline driver tests"?

I'll make these changes unless you suggest alternatives, [~szehon].  Here are 
the links:

* [Hive Developer FAQ -- How do I add a new MiniMR test? | 
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=27823747#HiveDeveloperFAQ-HowdoIaddanewMiniMRtest?]
* [Home -- Resources for Contributors (see Hive Developer Docs section, FAQ 
bullet) | 
https://cwiki.apache.org/confluence/display/Hive/Home#Home-ResourcesforContributors]
* [Developer Docs (umbrella page) | 
https://cwiki.apache.org/confluence/display/Hive/DeveloperDocs]
* [Hive PreCommit Patch Testing -- Short Version | 
https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing]



> Enhance Ptest framework config to auto-pick up list of MiniXXXDriver's test
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-7254
>                 URL: https://issues.apache.org/jira/browse/HIVE-7254
>             Project: Hive
>          Issue Type: Test
>          Components: Testing Infrastructure
>            Reporter: Szehon Ho
>            Assignee: Szehon Ho
>         Attachments: trunk-mr2.properties
>
>
> Today, the Hive PTest infrastructure has a test-driver configuration called 
> "directory", so it will run all the qfiles under that directory for that 
> driver.  For example, CLIDriver is configured with directory 
> "ql/src/test/queries/clientpositive"
> However the configuration for the miniXXXDrivers (miniMRDriver, 
> miniMRDriverNegative, miniTezDriver) run only a select number of tests under 
> "directory".  So we have to use the "include" configuration to hard-code a 
> list of tests for it to run.  This is duplicating the list of each 
> miniDriver's tests already in the /itests/qtest pom file, and can get out of 
> date.
> It would be nice if both got their information the same way.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to