----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23722/#review48915 -----------------------------------------------------------
This patch looks reasonable to me, just following minor comments. beeline/pom.xml <https://reviews.apache.org/r/23722/#comment85697> Can we fix formatting of the <dependency> blocks, by indenting two spaces? beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java <https://reviews.apache.org/r/23722/#comment85700> Looks strange for beeline to depend on zookeeper class, can we use another common-util? - Szehon Ho On July 22, 2014, 1:16 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23722/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 1:16 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7434 > https://issues.apache.org/jira/browse/HIVE-7434 > > > Repository: hive-git > > > Description > ------- > > HIVE-7434: refactor csv output format with in RFC mode > > > Diffs > ----- > > beeline/pom.xml 6ec1d1aff3f35c097aa6054aae84faf2d63854f1 > beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java > 7853c3f38f3c3fb9ae0b9939c714f1dc940ba053 > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java > 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f > pom.xml b5a5697e6a3b689c2b244ba0338be541261eaa3d > > Diff: https://reviews.apache.org/r/23722/diff/ > > > Testing > ------- > > UT > > > Thanks, > > cheng xu > >
