----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24084/#review49141 -----------------------------------------------------------
itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java <https://reviews.apache.org/r/24084/#comment85986> if the hook does not run these two NPE. Let's have an assertion first for not null ql/src/java/org/apache/hadoop/hive/ql/Driver.java <https://reviews.apache.org/r/24084/#comment85987> Let's put this in javadoc format service/src/java/org/apache/hive/service/cli/CLIService.java <https://reviews.apache.org/r/24084/#comment85988> If this should not happen, should we throw these? - Brock Noland On July 30, 2014, 2:13 a.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24084/ > ----------------------------------------------------------- > > (Updated July 30, 2014, 2:13 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7547 > https://issues.apache.org/jira/browse/HIVE-7547 > > > Repository: hive-git > > > Description > ------- > > Passing the ipAddress and userName (already calculated in ThriftCLIService > for other purposes) through several layers down to the hooks. > > > Diffs > ----- > > > itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java > PRE-CREATION > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/Driver.java e512199 > ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java b11cb86 > service/src/java/org/apache/hive/service/cli/CLIService.java add37a1 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > de54ca1 > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 9785e95 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 5c87bcb > > Diff: https://reviews.apache.org/r/24084/diff/ > > > Testing > ------- > > Added tests in both kerberos and non-kerberos mode. > > > Thanks, > > Szehon Ho > >
