> On Aug. 1, 2014, 8:32 a.m., Lars Francke wrote:
> > I'm not sure about this patch.
> >
> > Something like this will now be completely garbled:
> >
> > create table ${D_TBL} (d string);select * from ${D_TBL} where d = ";";
> > show tables;
> >
> > Even something like this won't work anymore:
> >
> > select * from ${D_TBL} where d = ";"
> >
> > So I'm afraid I'm on -1 on this patch as it breaks existing behavior. The
> > only way to do this properly is to parse the statement fully and split
> > where needed.
Lars that is a good point. However, hive cli also does not support queries with
";" as part of query with -e.
I do agree that we should have a better way to handle ";" and support multiple
queries at the same time with -e. I will try to see if there is something that
can be formulated with reasonable effort. Feel free to suggest any solution
that you have in mind.
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24086/#review49327
-----------------------------------------------------------
On July 31, 2014, 8:05 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24086/
> -----------------------------------------------------------
>
> (Updated July 31, 2014, 8:05 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7348
> https://issues.apache.org/jira/browse/HIVE-7348
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7348: Beeline could not parse ; separated queries provided with -e option
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java
> 10fd2e2daac78ca43d45c74fcbad6b720a8d28ad
>
> itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
> 8888bd97aff5959fd9040fc0f0a1f6b782f2aa6f
>
> Diff: https://reviews.apache.org/r/24086/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> Thanks,
>
> Ashish Singh
>
>
