[ 
https://issues.apache.org/jira/browse/HIVE-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088295#comment-14088295
 ] 

Jason Dere commented on HIVE-7618:
----------------------------------

I think the point of the test is that the test case should work properly 
without explicitly setting the table location. What I think we need here is a 
way to determine if the StorageHandler needs a location or not. We can either 
1. Add a new method to the StorageHandler interface (needsLocation()?), which 
we use in place of StorageDescriptor.isSetLocation(). The downside to this 
would be that this may break any existing 3rd party StorageHandlers, as 
mentioned in HIVE-6853.
2. DDLTask already has some HBaseStorageHandler-specific logic in 
showCreateTable(). We could make this logic into a needsLocation() routine 
within DDLTask itself, and use it in a similar way as described in (1).

> TestDDLWithRemoteMetastoreSecondNamenode unit test failure
> ----------------------------------------------------------
>
>                 Key: HIVE-7618
>                 URL: https://issues.apache.org/jira/browse/HIVE-7618
>             Project: Hive
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: HIVE-7618.1.patch
>
>
> Looks like TestDDLWithRemoteMetastoreSecondNamenode started failing after 
> HIVE-6584 was committed.
> {noformat}
> TestDDLWithRemoteMetastoreSecondNamenode.testCreateTableWithIndexAndPartitionsNonDefaultNameNode:272->createTableAndCheck:201->createTableAndCheck:219
>  Table should be located in the second filesystem expected:<[hdfs]> but 
> was:<[pfile]>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to