[ 
https://issues.apache.org/jira/browse/HIVE-4806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093105#comment-14093105
 ] 

Alexander Pivovarov commented on HIVE-4806:
-------------------------------------------

I found at least 2 issues with HIVE-4806.patch

1. getIdentifierQuoteString  returns '
Actually there is a limited support for quoting identifiers in hive.  You can 
quote column names but not database or table names.
It means that IdentifierQuoteString is not fully supported and most probably 
getIdentifierQuoteString should return space (according to JDBC spec).
This method returns a space " " if identifier quoting is not supported.
In this case SQL client will generate correct sql statements (without quotes 
for column, table and database names).

2. isReadOnly returns true.  Also method description says "Returns a true as 
the database meta data is readonly."
in fact JDBC spec defines this method as "Retrieves whether this database is in 
read-only mode."    So, it's about database but not about metadata.

In most cases hive databases are NOT readonly.  We can run "create table as 
select", "insert into table",   "insert overwrite"
I think isReadOnly should return false.

Look at my patch HIVE-7676





> Add more implementations of JDBC API methods to Hive and Hive2 drivers
> ----------------------------------------------------------------------
>
>                 Key: HIVE-4806
>                 URL: https://issues.apache.org/jira/browse/HIVE-4806
>             Project: Hive
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions: 0.11.0
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>         Attachments: HIVE-4806.patch
>
>
> Third-party client software such as Pentaho Data Integration (PDI) uses many 
> different JDBC API calls when interacting with JDBC data sources. Several of 
> these calls have not yet been implemented in the Hive and Hive 2 drivers and 
> by default will throw "Method not supported" SQLExceptions when there could 
> be default implementations instead.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to