> On Aug. 7, 2014, 12:02 a.m., Szehon Ho wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 252 > > <https://reviews.apache.org/r/23320/diff/2/?file=653814#file653814line252> > > > > It can still be final even if static.
Yup, can be made final now. In the previous patch I was setting it in background thread from the handler thread, that's why had to keep it non-final. > On Aug. 7, 2014, 12:02 a.m., Szehon Ho wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 260 > > <https://reviews.apache.org/r/23320/diff/2/?file=653814#file653814line260> > > > > Doesnt look like these methods are used? setRawStore won't be used now. getRawStore is used. removeRawStore might be a useful encapsulation. - Vaibhav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23320/#review49832 ----------------------------------------------------------- On Aug. 6, 2014, 4:11 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23320/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 4:11 p.m.) > > > Review request for hive, Navis Ryu, Sushanth Sowmyan, Szehon Ho, and Thejas > Nair. > > > Bugs: HIVE-7353 > https://issues.apache.org/jira/browse/HIVE-7353 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-7353 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8490558 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > ff282c5 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 760777a > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ebf2443 > service/src/java/org/apache/hive/service/cli/CLIService.java 80d7b82 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > de54ca1 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > b39d64d > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > c2f0495 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java > b009a88 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > be2eb01 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > 98d75b5 > > service/src/java/org/apache/hive/service/server/ThreadFactoryWithGarbageCleanup.java > PRE-CREATION > > service/src/java/org/apache/hive/service/server/ThreadWithGarbageCleanup.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23320/diff/ > > > Testing > ------- > > Manual testing using Yourkit. > > > Thanks, > > Vaibhav Gumashta > >
