----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24689/#review50553 -----------------------------------------------------------
Ship it! Looks fine to me. - Szehon Ho On Aug. 14, 2014, 2:43 a.m., chengxiang li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24689/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 2:43 a.m.) > > > Review request for hive, Brock Noland and Szehon Ho. > > > Bugs: HIVE-7707 > https://issues.apache.org/jira/browse/HIVE-7707 > > > Repository: hive-git > > > Description > ------- > > Current SparkRecordHandler is cloned from ExecMapper, which introduce several > unnecessary API restriction and MR specified logic. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java > 7befaee > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunctionResultList.java > 8e05011 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java > 52324c9 > > Diff: https://reviews.apache.org/r/24689/diff/ > > > Testing > ------- > > > Thanks, > > chengxiang li > >