> On Aug. 25, 2014, 6:48 p.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 1549 > > <https://reviews.apache.org/r/24830/diff/1/?file=663983#file663983line1549> > > > > Use named capture in java as much as possible. > > > > (?<taskId>[0-9]+) etc.
Named capture is supported only in JDK7 and above. Using comments in next patch to maintain compat. > On Aug. 25, 2014, 6:48 p.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java, line 1877 > > <https://reviews.apache.org/r/24830/diff/1/?file=663983#file663983line1877> > > > > What about LOAD DATA INPATH? By "LOAD .. INTO" in comment I meant meant "LOAD DATA INPATH .. INTO TABLE".. Please look at my previous comment for Gunther's question in review board for LOAD DATA example. - Prasanth_J ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24830/#review51424 ----------------------------------------------------------- On Aug. 19, 2014, 12:29 a.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24830/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2014, 12:29 a.m.) > > > Review request for hive and Gunther Hagleitner. > > > Repository: hive-git > > > Description > ------- > > ORC fast merge (HIVE-7509) will fail the merge task in case if any of the > precondition checks fail. Precondition check fail is good for "ALTER TABLE .. > CONCATENATE" but not for automatic trigger of merge task from conditional > resolver. In case if a partition has non-compatible ORC files for merging > then the merge task should ignore it and not fail the task. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1d6a93a > ql/src/java/org/apache/hadoop/hive/ql/io/merge/MergeMapper.java beb4f7d > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileMergeMapper.java > b36152a > ql/src/test/queries/clientnegative/orc_merge1.q b2d42cd > ql/src/test/queries/clientnegative/orc_merge2.q 2f62ee7 > ql/src/test/queries/clientnegative/orc_merge3.q 5158e2e > ql/src/test/queries/clientnegative/orc_merge4.q ad48572 > ql/src/test/queries/clientnegative/orc_merge5.q e94a8cc > ql/src/test/queries/clientpositive/orc_merge_incompat1.q PRE-CREATION > ql/src/test/queries/clientpositive/orc_merge_incompat2.q PRE-CREATION > ql/src/test/results/clientpositive/orc_merge_incompat1.q.out PRE-CREATION > ql/src/test/results/clientpositive/orc_merge_incompat2.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/24830/diff/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >
