----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25086/#review51636 -----------------------------------------------------------
Looks good overall, just a minor comment below. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java <https://reviews.apache.org/r/25086/#comment90120> Please put a space after the cast, and let's get rid of the useless assignment in the below line, even though its like that in other inspectors. - Szehon Ho On Aug. 27, 2014, 12:55 a.m., Mohit Sabharwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25086/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 12:55 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7889 > https://issues.apache.org/jira/browse/HIVE-7889 > > > Repository: hive-git > > > Description > ------- > > For a char partition column, JavaHiveCharObjectInspector attempts to cast > HiveCharWritable to HiveChar. > > Similar issue for Varchar was fixed in HIVE-6642. > > > Diffs > ----- > > ql/src/test/queries/clientpositive/partition_char.q PRE-CREATION > ql/src/test/results/clientpositive/partition_char.q.out PRE-CREATION > > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveCharObjectInspector.java > ff114c04f396fa3b51aa6c065ae019dac2db3a81 > > Diff: https://reviews.apache.org/r/25086/diff/ > > > Testing > ------- > > Added q-test > > > Thanks, > > Mohit Sabharwal > >
