----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21679/#review51256 -----------------------------------------------------------
itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java <https://reviews.apache.org/r/21679/#comment89357> please use a name that better indicates that it is a boolean. eg isRemoteMetastore itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java <https://reviews.apache.org/r/21679/#comment89358> this status is unused - Thejas Nair On Aug. 20, 2014, 10:33 p.m., Venki Korukanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21679/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 10:33 p.m.) > > > Review request for hive, Navis Ryu, Thejas Nair, and Vaibhav Gumashta. > > > Bugs: HIVE-6245 > https://issues.apache.org/jira/browse/HIVE-6245 > > > Repository: hive-git > > > Description > ------- > > Instead of creating Hive object when authentication type is "KERBEROS", > always create the Hive object in HiveSessionImplWithUGI. > HiveSessionImplWithUGI is created when user impersonation is needed. > > > Diffs > ----- > > itests/hive-unit/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java > 4502439 > > itests/hive-unit/src/test/java/org/apache/hive/service/TestHS2ImpersonationWithRemoteMS.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 51c3f2c > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > 39d2184 > > Diff: https://reviews.apache.org/r/21679/diff/ > > > Testing > ------- > > Patch includes a test. > > > Thanks, > > Venki Korukanti > >
