[ 
https://issues.apache.org/jira/browse/HIVE-7921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116258#comment-14116258
 ] 

Szehon Ho commented on HIVE-7921:
---------------------------------

+1, thanks for the cleanup.

> Fix confusing dead assignment in return statement 
> (JavaHiveVarcharObjectInspector)
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-7921
>                 URL: https://issues.apache.org/jira/browse/HIVE-7921
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Lars Francke
>            Assignee: Lars Francke
>            Priority: Minor
>         Attachments: HIVE-7921.1.patch
>
>
> There are multiple instances of something like this {{return o = new 
> HiveVarchar(value, getMaxLength());}} in this class. That's not only 
> confusing but also useless as it doesn't do anything.
> I've removed those assignments and cleaned up the class a bit.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to