----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15449/#review51951 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90645> Shouldn't this have a TimeValidator? common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90646> Again, no TimeValidator. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90647> No TimeValidator. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90648> No TimeValidator. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/15449/#comment90649> Lack of TimeValidator here is deliberate, right? - Lefty Leverenz On Aug. 29, 2014, 9:05 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15449/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2014, 9:05 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5799 > https://issues.apache.org/jira/browse/HIVE-5799 > > > Repository: hive-git > > > Description > ------- > > Need some timeout facility for preventing resource leakages from instable or > bad clients. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/ant/GenHiveTemplate.java 4293b7c > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 74bb863 > common/src/java/org/apache/hadoop/hive/conf/Validator.java cea9c41 > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestRetryingHMSHandler.java > 39e7005 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2SessionTimeout.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 9e3481a > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 4e76236 > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java > 84e6dcd > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > 063dee6 > metastore/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java > 8287c60 > ql/src/java/org/apache/hadoop/hive/ql/exec/AutoProgressor.java d7323cb > ql/src/java/org/apache/hadoop/hive/ql/exec/Heartbeater.java 7fdb4e7 > ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 5b857e2 > ql/src/java/org/apache/hadoop/hive/ql/exec/UDTFOperator.java afd7bcf > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 70047a2 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java > eb2851b > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java ebe9f92 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockManager.java > 11434a0 > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > 46044d0 > ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsAggregator.java > f636cff > ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsPublisher.java > db62721 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java 3211759 > ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestInitiator.java > f34b5ad > ql/src/test/results/clientnegative/set_hiveconf_validation2.q.out 33f9360 > service/src/java/org/apache/hadoop/hive/service/HiveServer.java 32729f2 > service/src/java/org/apache/hive/service/cli/CLIService.java ff5de4a > service/src/java/org/apache/hive/service/cli/OperationState.java 3e15f0c > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 0d6436e > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 2867301 > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 270e4a6 > service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java > 84e1c7e > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 4e5f595 > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > 7668904 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 17c1c7b > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 86ed4b4 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > 21d1563 > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java d01e819 > > Diff: https://reviews.apache.org/r/15449/diff/ > > > Testing > ------- > > Confirmed in the local environment. > > > Thanks, > > Navis Ryu > >
