[
https://issues.apache.org/jira/browse/HIVE-7933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14117837#comment-14117837
]
Brock Noland edited comment on HIVE-7933 at 9/2/14 2:36 AM:
------------------------------------------------------------
1) I think we should a step similar to {{PrepPhase}} but runs after
{{PrepPhase}}:
https://github.com/apache/hive/blob/trunk/testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PrepPhase.java
call it {{CheckStylePhase}} which does this check.
2) We can change the Phase interface so that {{CheckStylePhase}} can add
messages posted to the JIRA.
was (Author: brocknoland):
1) I think we should a step similar to {{PrepPhas}} but runs after
{{PrepPhase}}:
https://github.com/apache/hive/blob/trunk/testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PrepPhase.java
call it {{CheckStylePhase}} which does this check.
2) We can change the Phase interface so that {{CheckStylePhase}} can add
messages posted to the JIRA.
> Ensure new patches do not introduce checkstyle violations
> ---------------------------------------------------------
>
> Key: HIVE-7933
> URL: https://issues.apache.org/jira/browse/HIVE-7933
> Project: Hive
> Issue Type: Improvement
> Reporter: Brock Noland
>
> Using the precommit build we can store a copy of the current checkstyle
> violations and then ensure that the new patch does not introduce any new ones.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
