----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25460/#review52656 -----------------------------------------------------------
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java <https://reviews.apache.org/r/25460/#comment91541> can you also add a test for dir with multiple levels of dirs (that need to get created)? Also, please use System.getProperty("test.tmp.dir"), instead of "/tmp" ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/25460/#comment91537> I guess this issue might have existed in the old code as well - We are loosing the error message here, if the mkdirs fails. Maybe change this to try { retval = fs.mkdirs(mkdirPath, fsPermission); resetConf(conf, recursive, origUmask); } catch (IOException ioe) { resetConf(conf, recursive, origUmask); throw ioe; } finally { IOUtils.closeStream(fs); } A cleaner solution would have been to use Closer in guava, but it requires upgrade to guava 14, I am not sure if you want to go into that as part of this patch- https://code.google.com/p/guava-libraries/wiki/ClosingResourcesExplained - Thejas Nair On Sept. 8, 2014, 11:23 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25460/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 11:23 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-8022 > https://issues.apache.org/jira/browse/HIVE-8022 > > > Repository: hive-git > > > Description > ------- > > Recursive root scratch directory creation is not using hdfs umask properly > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > 5dce16f > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5bbf3f6 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 47fe508 > > Diff: https://reviews.apache.org/r/25460/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
