----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25468/#review52723 -----------------------------------------------------------
Great work! serde/pom.xml <https://reviews.apache.org/r/25468/#comment91700> These should only be indented by two spaces, not four. Have you tried submitting an MR job on a cluster with this patch? The reason I ask is that I think the serde must be in here: https://github.com/apache/hive/blob/trunk/ql/pom.xml#L563 for it to be available to MR jobs. serde/src/java/org/apache/hadoop/hive/serde2/CSVSerde.java <https://reviews.apache.org/r/25468/#comment91701> I think we should call this OpenCSVSerde since it's based on OpenCSV and I believe we might see multiple implementations of CSVSerde. I think we should extend AbstractSerde as that is what all the new Serdes are supposed to be doing. - Brock Noland On Sept. 9, 2014, 2:16 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25468/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 2:16 a.m.) > > > Review request for hive. > > > Bugs: HIVE-7777 > https://issues.apache.org/jira/browse/HIVE-7777 > > > Repository: hive-git > > > Description > ------- > > HIVE-7777: add CSVSerde support > > > Diffs > ----- > > serde/pom.xml f8bcc830cfb298d739819db8fbaa2f98f221ccf3 > serde/src/java/org/apache/hadoop/hive/serde2/CSVSerde.java PRE-CREATION > serde/src/test/org/apache/hadoop/hive/serde2/TestCSVSerde.java PRE-CREATION > > Diff: https://reviews.apache.org/r/25468/diff/ > > > Testing > ------- > > Unit test > > > Thanks, > > cheng xu > >
