[ 
https://issues.apache.org/jira/browse/HIVE-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128507#comment-14128507
 ] 

Brock Noland commented on HIVE-8035:
------------------------------------

+1

The test {{TestOrcHCatLoader.testReadDataPrimitiveTypes}} seems to be quite 
flaky.

with regards to {{limit_pushdown.q}}, I think the test that is important there 
is that the limit is pushed down as shown in the explain plan. It's not a 
correctness test for order by.

> Add SORT_QUERY_RESULTS for test that doesn't guarantee order
> ------------------------------------------------------------
>
>                 Key: HIVE-8035
>                 URL: https://issues.apache.org/jira/browse/HIVE-8035
>             Project: Hive
>          Issue Type: Test
>          Components: Tests
>            Reporter: Rui Li
>            Assignee: Rui Li
>            Priority: Minor
>         Attachments: HIVE-8035.patch
>
>
> Some test query doesn't guarantee output order, e.g. group by, union all. 
> Therefore we should add {{-- SORT_QUERY_RESULTS}} to the qfiles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to