[ https://issues.apache.org/jira/browse/HIVE-5799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130136#comment-14130136 ]
Brock Noland commented on HIVE-5799: ------------------------------------ Hi [~navis], I had a quick question but the code below. Is the case where operationTimeout < 0 a normal case? If not, should we return false there? {noformat} + if (operationTimeout > 0) { + // check only when it's in terminal state + return state.isTerminal() && lastAccessTime + operationTimeout <= current; + } + return lastAccessTime + -operationTimeout <= current; {noformat} > session/operation timeout for hiveserver2 > ----------------------------------------- > > Key: HIVE-5799 > URL: https://issues.apache.org/jira/browse/HIVE-5799 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 > Reporter: Navis > Assignee: Navis > Priority: Minor > Labels: TODOC14 > Fix For: 0.14.0 > > Attachments: HIVE-5799.1.patch.txt, HIVE-5799.10.patch.txt, > HIVE-5799.11.patch.txt, HIVE-5799.12.patch.txt, HIVE-5799.13.patch.txt, > HIVE-5799.14.patch.txt, HIVE-5799.15.patch.txt, HIVE-5799.16.patch.txt, > HIVE-5799.17.patch.txt, HIVE-5799.2.patch.txt, HIVE-5799.3.patch.txt, > HIVE-5799.4.patch.txt, HIVE-5799.5.patch.txt, HIVE-5799.6.patch.txt, > HIVE-5799.7.patch.txt, HIVE-5799.8.patch.txt, HIVE-5799.9.patch.txt > > > Need some timeout facility for preventing resource leakages from instable or > bad clients. -- This message was sent by Atlassian JIRA (v6.3.4#6332)