----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25245/#review53067 -----------------------------------------------------------
service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/25245/#comment92456> Should we use READ_ACL_UNSAFE here ? service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/25245/#comment92467> Its safer to first set the boolean and then set the watcher, to avoid potential race conditions. Otherwise, in theory you can have a case where node gets deleted, watcher sets boolean to false, and then this line sets it to true. Also, the "this." for the function call seems unnecessary. We should also check if the exists call returns null (which indicates that file does not exist). call stop in that case ? service/src/java/org/apache/hive/service/server/HiveServer2.java <https://reviews.apache.org/r/25245/#comment92474> I think we should check here as well, if it is OK to shut down the server. Consider the case of a rolling upgrade late in the night, when the cluster might not be very active. There might not be any remaining active connections on this server. And since it is removed from the zookeeper, no new connections would be established, and server would not come down by itself. - Thejas Nair On Sept. 11, 2014, 1:08 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25245/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 1:08 p.m.) > > > Review request for hive, Alan Gates, Navis Ryu, Szehon Ho, and Thejas Nair. > > > Bugs: HIVE-7935 > https://issues.apache.org/jira/browse/HIVE-7935 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-7935 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5d2e6b0 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > ae128a9 > jdbc/pom.xml 1ad13a7 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java cbcfec7 > jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java 6e248d6 > jdbc/src/java/org/apache/hive/jdbc/JdbcUriParseException.java PRE-CREATION > jdbc/src/java/org/apache/hive/jdbc/Utils.java 58339bf > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientException.java > PRE-CREATION > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > 0919d2f > ql/src/java/org/apache/hadoop/hive/ql/util/ZooKeeperHiveHelper.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/zookeeper/TestZookeeperLockManager.java > 59294b1 > service/src/java/org/apache/hive/service/cli/CLIService.java a0bc905 > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > f5a8f27 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > b0bb8be > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 11d25cc > > service/src/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java > 2b80adc > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 443c371 > > service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java > 4067106 > service/src/java/org/apache/hive/service/server/HiveServer2.java 124996c > > service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java > 66fc1fc > > Diff: https://reviews.apache.org/r/25245/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Vaibhav Gumashta > >
