----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25678/ -----------------------------------------------------------
Review request for hive. Bugs: HIVE-7588 https://issues.apache.org/jira/browse/HIVE-7588 Repository: hive-git Description ------- >From http://www.mail-archive.com/user@hive.apache.org/msg12307.html Support type variables in UDF {code} public <T> T evaluate(final T s, final String column_name, final int bitmap) throws Exception { if (s instanceof Double) return (T) new Double(-1.0); Else if( s instance of Integer) Return (T) new Integer(-1) ; ….. } {code} Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/exec/ComparisonOpMethodResolver.java 41a9cb3 ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java c503bbb ql/src/java/org/apache/hadoop/hive/ql/exec/NumericOpMethodResolver.java b056554 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBridge.java e471285 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java 1f70c55 ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestRecordReaderImpl.java 3e43ade ql/src/test/org/apache/hadoop/hive/ql/udf/UDFObjectToString.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/udf/UDFTypeVariable.java PRE-CREATION ql/src/test/queries/clientpositive/udf_generics.q PRE-CREATION ql/src/test/results/clientpositive/udf_generics.q.out PRE-CREATION serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java d7affae serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java 78e6066 serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ThriftUnionObjectInspector.java 17add28 serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 8dffe63 Diff: https://reviews.apache.org/r/25678/diff/ Testing ------- Thanks, Navis Ryu