----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25700/#review53546 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java <https://reviews.apache.org/r/25700/#comment93239> Is hive token case insensitive or all function names are in lower case? ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java <https://reviews.apache.org/r/25700/#comment93240> are all functions qualified in hive (w.r.t DB) How about built in functions like "toLower"? Could you say <DB NAME>.toLower()? - John Pullokkaran On Sept. 16, 2014, 5:23 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25700/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 5:23 p.m.) > > > Review request for hive, Ashutosh Chauhan and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java c503bbb > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/RexNodeConverter.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/SqlFunctionConverter.java > PRE-CREATION > ql/src/test/queries/clientpositive/create_func1.q ad924d3 > ql/src/test/results/clientpositive/create_func1.q.out 798f77f > > Diff: https://reviews.apache.org/r/25700/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >