> On Sept. 13, 2014, 3:54 a.m., Xuefu Zhang wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 1409 > > <https://reviews.apache.org/r/25178/diff/3/?file=684101#file684101line1409> > > > > Maybe I wasn't clear, I was only talking about the two methods added in > > this patch: deletePartitionData(Path, EnvironmentContext) and > > deleteTableData(Path, EnvironmentContext). Instead of take 2nd param as > > this context, take a boolean. Callers will only need to pass a boolean. > > Also, both methods are new and private. I'm not sure if I undertand the > > complexity of the change. > > david seraf wrote: > I misunderstood. I'm fine with changing those 2 methods.
I looked at this in more detail and the problem is that dropTableData() is called from drop_table_with_environment_context(), which _is_ public and uses EnvironmentContext, so this change would have to propagate out to the interface class, which I'd rather not do just to make the code a little tidier. - david ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25178/#review53259 ----------------------------------------------------------- On Sept. 12, 2014, 9:51 p.m., david seraf wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25178/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 9:51 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-7100 > https://issues.apache.org/jira/browse/HIVE-7100 > > > Repository: hive-git > > > Description > ------- > > Add PURGE option to DROP TABLE command to skip saving table data to the trash > > > Diffs > ----- > > > hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitionPublish.java > be7134f > > hcatalog/webhcat/svr/src/test/java/org/apache/hive/hcatalog/templeton/tool/TestTempletonUtils.java > af952f2 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2.java > da51a55 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 9489949 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > a94a7a3 > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreFsImpl.java > cff0718 > metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java > cbdba30 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreFS.java > a141793 > metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 613b709 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java cd017d8 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java e387b8f > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 4cf98d8 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > f31a409 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 32db0c7 > ql/src/java/org/apache/hadoop/hive/ql/plan/DropTableDesc.java ba30e1f > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 406aae9 > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveRemote.java 1a5ba87 > ql/src/test/queries/clientpositive/drop_table_purge.q PRE-CREATION > ql/src/test/results/clientpositive/drop_table_purge.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/25178/diff/ > > > Testing > ------- > > added code test and added QL test. Tests passed in CI, but other, unrelated > tests failed. > > > Thanks, > > david seraf > >
