[
https://issues.apache.org/jira/browse/HIVE-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139921#comment-14139921
]
Dong Chen commented on HIVE-8138:
---------------------------------
Hi [~brocknoland], the patch looks good. Thanks for making the global init file
better.
Just one small comment about code style.
Can we add a newline between the first two test case in
TestSessionGlobalInitFile.java?
BTW, to rebase the patch, I remember a Jira has renamed the property
"HIVE_GLOBAL_INIT_FILE_LOCATION" to "HIVE_SERVER2_GLOBAL_..." for consistency.
Maybe renaming the property in this patch will fix the merging confilct.
> Global Init file should allow specifying file name not only directory
> ----------------------------------------------------------------------
>
> Key: HIVE-8138
> URL: https://issues.apache.org/jira/browse/HIVE-8138
> Project: Hive
> Issue Type: Bug
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: HIVE-8138.patch
>
>
> HIVE-5160 allows you to specify a directory where a .hiverc file exists.
> However since .hiverc is a hidden file this can be confusing. The property
> should allow a path to a file or a directory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
