----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25754/#review53986 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java <https://reviews.apache.org/r/25754/#comment93862> Instead of these changes why don't you use FunctionRegistry.getTypeInfoForPrimitiveCategory(a,b) - John Pullokkaran On Sept. 17, 2014, 9:25 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25754/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 9:25 p.m.) > > > Review request for hive, Ashutosh Chauhan and John Pullokkaran. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/RexNodeConverter.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java > 6131d3d > ql/src/test/queries/clientpositive/decimal_udf.q 591c210 > ql/src/test/results/clientpositive/decimal_udf.q.out c5c2031 > > Diff: https://reviews.apache.org/r/25754/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
