[ 
https://issues.apache.org/jira/browse/HIVE-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142577#comment-14142577
 ] 

Thejas M Nair commented on HIVE-8094:
-------------------------------------

[~peter_liu], Thanks for working on this ! It would be great to support the 
same LIKE semantics as one used with show tables and databases.

A few comments
# We should avoid breaking backward compatibility as far as possible. This 
patch seems to makes some of the earlier regexes invalid (please correct me if 
I am wrong). In this case since we are introducing a new keyword, we have the 
opportunity to make this change without breaking backward compability. ie, we 
could use the like style regex only when LIKE keyword is used. We can then 
document the old syntax without LIKE as deprecated. Lets keep the existing test 
statements for the old syntax around.
# Now that we have permanent udfs, the getFunctions calls results in metastore 
api calls. We should make calls to this api from outside/before the loop.


Please create a reviewboard link when you upload a new patch. 
(reviews.apache.org).


> add LIKE keyword support for SHOW FUNCTIONS
> -------------------------------------------
>
>                 Key: HIVE-8094
>                 URL: https://issues.apache.org/jira/browse/HIVE-8094
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.14.0, 0.13.1
>            Reporter: peter liu
>            Assignee: peter liu
>             Fix For: 0.14.0
>
>         Attachments: HIVE-8094.1.patch, HIVE-8094.2.patch
>
>
> It would be nice to  add LIKE keyword support for SHOW FUNCTIONS as below, 
> and keep the patterns consistent to the way as SHOW DATABASES, SHOW TABLES.
> bq. SHOW FUNCTIONS LIKE 'foo*';



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to