[
https://issues.apache.org/jira/browse/HIVE-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145392#comment-14145392
]
Thejas M Nair commented on HIVE-7107:
-------------------------------------
Lars,
I usually prefer large cleanups (relative to the fix) to be done as part of
separate jira. That way it is easier to determine what part was the actual fix,
while looking at svn/git history. I feel around 10-20% of changes in a bug fix
being cleanup is OK, but more than 80% of the changes for a bug fix being
cleanup makes it little difficult to handle.
I can review a separate HiveServer* cleanup patch in another jira.
> Clean up HiveDrivers and fix an issue
> -------------------------------------
>
> Key: HIVE-7107
> URL: https://issues.apache.org/jira/browse/HIVE-7107
> Project: Hive
> Issue Type: Bug
> Reporter: Lars Francke
> Assignee: Lars Francke
> Priority: Minor
> Attachments: HIVE-7107.2.patch
>
>
> The HiveServer1 driver does not adhere to the JDBC standard of returning null
> when it can't handle a connection URL. It instead throws an exception which
> leads to subsequent exceptions (from other drivers, i.e. the HiveServer2 one)
> being swallowed.
> This is what you'd see:
> {quote}
> Error: Invalid URL:
> jdbc:hive2://localhost:10000/default;principal=hive/_h...@example.com
> (state=08S01,code=0)
> java.sql.SQLException: Invalid URL:
> jdbc:hive2://localhost:10000/default;principal=hive/_h...@example.com
> at
> org.apache.hadoop.hive.jdbc.HiveConnection.<init>(HiveConnection.java:86)
> {quote}
> In addition this patch cleans up the drivers a bit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
