[jira] [Commented] (HIVE-6148) Support arbitrary structs stored in HBase

[Brock Noland (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HIVE-6148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148427#comment-14148427
 ] 

Brock Noland commented on HIVE-6148:
------------------------------------

Patch looks good and I am +1, but I still see:

{noformat}
@@ -1403,6 +1484,8 @@ private void deserializeAndSerializeHiveAvro(HBaseSerDe 
serDe, Result r, Put p,
       assertNotNull(fieldData);
       assertEquals(expectedFieldsData[j], fieldData.toString().trim());
     }
+    
+    SerDeUtils.getJSONString(row, soi);
 
     // Now serialize
     Put put = ((PutWritable) serDe.serialize(row, soi)).getPut();
{noformat}

which doesn't seem to make sense?

> Support arbitrary structs stored in HBase
> -----------------------------------------
>
>                 Key: HIVE-6148
>                 URL: https://issues.apache.org/jira/browse/HIVE-6148
>             Project: Hive
>          Issue Type: Improvement
>          Components: HBase Handler
>    Affects Versions: 0.12.0
>            Reporter: Swarnim Kulkarni
>            Assignee: Swarnim Kulkarni
>         Attachments: HIVE-6148.1.patch.txt, HIVE-6148.2.patch.txt
>
>
> We should add support to be able to query arbitrary structs stored in HBase.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)