[ 
https://issues.apache.org/jira/browse/HIVE-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161367#comment-14161367
 ] 

Harish Butani commented on HIVE-8280:
-------------------------------------

Other ops are handled by RelMdUniqueKeys.
will remove tail recursion: (i was thinking scala)

> CBO : When filter is applied on dimension table PK/FK code path is not in 
> effect.
> ---------------------------------------------------------------------------------
>
>                 Key: HIVE-8280
>                 URL: https://issues.apache.org/jira/browse/HIVE-8280
>             Project: Hive
>          Issue Type: Bug
>          Components: CBO
>    Affects Versions: 0.14.0
>            Reporter: Mostafa Mokhtar
>            Assignee: Harish Butani
>             Fix For: 0.14.0
>
>         Attachments: HIVE-8280.1.patch
>
>
> When a filter is applied on PK side joins don't qualify as PK/FK join.
> In getUniqueKeys when a filter is applied on the table the child is no  
> longer a table scan.
> {code}
>   public Set<BitSet> getUniqueKeys(ProjectRelBase rel, boolean ignoreNulls) {
>     RelNode child = rel.getChild();
>     if (!(child instanceof HiveTableScanRel)) {
>       Function<RelNode, Metadata> fn = RelMdUniqueKeys.SOURCE.apply(
>           rel.getClass(), BuiltInMetadata.UniqueKeys.class);
>       return ((BuiltInMetadata.UniqueKeys) fn.apply(rel))
>           .getUniqueKeys(ignoreNulls);
>     } 
> {code}
> Repro 
> {code}
> with ss as 
> (select 
>     ss_customer_sk, ss_item_sk, ss_ticket_number
> from
>     store_sales,
>     store
> where
>     s_store_sk = ss_store_sk
>         and s_market_id = 4), 
> sr as
> (select sr_customer_sk,sr_item_sk ,sr_ticket_number from store_returns, store 
> where s_store_sk = sr_store_sk and s_market_id=4) 
> select 
>     count(*)
> from
>     ss,
>     sr
> where
>     ss_customer_sk = sr_customer_sk
>         and ss_item_sk = sr_item_sk
>         and ss_ticket_number = sr_ticket_number;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to