----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26573/#review56254 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java <https://reviews.apache.org/r/26573/#comment96563> should this also check if it's deterministic? - Sergey Shelukhin On Oct. 10, 2014, 8:53 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26573/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 8:53 p.m.) > > > Review request for hive. > > > Bugs: HIVE-8428 > https://issues.apache.org/jira/browse/HIVE-8428 > > > Repository: hive > > > Description > ------- > > PCR doesnt remove filters involving casts > > > Diffs > ----- > > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java > 1630984 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrOpProcFactory.java > 1630984 > trunk/ql/src/test/queries/clientpositive/pcr.q 1630984 > trunk/ql/src/test/results/clientpositive/pcr.q.out 1630984 > > Diff: https://reviews.apache.org/r/26573/diff/ > > > Testing > ------- > > New tests in pcr.q > > > Thanks, > > Ashutosh Chauhan > >
