Lars Francke created HIVE-8583: ---------------------------------- Summary: HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist Key: HIVE-8583 URL: https://issues.apache.org/jira/browse/HIVE-8583 Project: Hive Issue Type: Improvement Reporter: Lars Francke Assignee: Lars Francke Priority: Minor
[~alangates] added the following in HIVE-8341: {code} String bl = hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString()); if (bl != null && bl.length() > 0) { String[] bls = bl.split(","); for (String b : bls) { b.replaceAll(".", "_"); blackListedConfEntries.add(b); } } {code} The {{replaceAll}} call is confusing as its result is not used at all. This patch contains the following: * Minor style modification (missorted modifiers) * Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST * Removes replaceAll * Lets blackListed take a Configuration job as parameter which allowed me to add a test for this -- This message was sent by Atlassian JIRA (v6.3.4#6332)