[
https://issues.apache.org/jira/browse/HIVE-8576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182056#comment-14182056
]
Hive QA commented on HIVE-8576:
-------------------------------
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12676654/HIVE-8576.1.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 6578 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_join_pkfk
org.apache.hive.minikdc.TestJdbcWithMiniKdc.testNegativeTokenAuth
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1418/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1418/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1418/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12676654 - PreCommit-HIVE-TRUNK-Build
> Guaranteed NPE in StatsRulesProcFactory
> ---------------------------------------
>
> Key: HIVE-8576
> URL: https://issues.apache.org/jira/browse/HIVE-8576
> Project: Hive
> Issue Type: Bug
> Reporter: Lars Francke
> Assignee: Lars Francke
> Attachments: HIVE-8576.1.patch
>
>
> Code looks like this:
> {code}
> private List<Integer> getPrimaryKeyCandidates(List<Operator<? extends
> OperatorDesc>> ops) {
> List<Integer> result = Lists.newArrayList();
> if (ops != null || !ops.isEmpty()) {
> for (int i = 0; i < ops.size(); i++) {
> {code}
> The {{||}} should be {{&&}} as the current {{if}} statement can be rewritten
> as {{!(ops == null && ops.isEmpty())}} which doesn't make sense.
> Or am I missing something?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
