----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27367/#review59279 -----------------------------------------------------------
I think this looks good. Would you be able to add a test using timestamp literals as a partition column? Just to make sure we don't get a repeat of HIVE-4928 for timestamp. - Jason Dere On Oct. 30, 2014, 12:52 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27367/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2014, 12:52 a.m.) > > > Review request for hive. > > > Bugs: HIVE-3187 > https://issues.apache.org/jira/browse/HIVE-3187 > > > Repository: hive-git > > > Description > ------- > > Enable the JDBC driver/Hive SQL engine to accept JDBC canonical or ISO-SQL > 20xx Timestamp literals > > ie. > select 1 from cert.tversion tversion where timestamp '1989-01-01 > 10:20:30.000000000' <> timestamp '2000-12-31 12:15:30.123000000' > > instead of > unix_timestamp('.....) > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g c903e8f > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 13d5255 > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > e065983 > ql/src/test/queries/clientnegative/timestamp_literal.q PRE-CREATION > ql/src/test/queries/clientpositive/timestamp_literal.q PRE-CREATION > ql/src/test/results/clientnegative/date_literal2.q.out 82f6425 > ql/src/test/results/clientnegative/date_literal3.q.out 82f6425 > ql/src/test/results/clientnegative/illegal_partition_type4.q.out e388086 > ql/src/test/results/clientnegative/timestamp_literal.q.out PRE-CREATION > ql/src/test/results/clientpositive/timestamp_literal.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/27367/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
