----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27640/#review60278 -----------------------------------------------------------
Few comments about the patch: It is triggered only when RS-MJ is found in the operator graph with ReduceSink the parent of Map-Join operator. So this correctly identifies ReduceSinks to convert to HashTableSink and does not inadvertently convert other RSs as demonstrated in the example nested query plan in the Join Optimization document - “explain select * FROM (SELECT avg(key) as x1, value as x2 FROM src group by value) x JOIN (SELECT avg(key) as y1, value as y2 FROM src group by value) y ON (x1 = y1)” - Suhas Satish On Nov. 6, 2014, 11:43 p.m., Suhas Satish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27640/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 11:43 p.m.) > > > Review request for hive, Chao Sun, Jimmy Xiang, Szehon Ho, and Xuefu Zhang. > > > Repository: hive-git > > > Description > ------- > > This replaces ReduceSinks with HashTableSinks in smaller tables for a > map-join. But the condition check field to detect map-join is actually being > set in CommonJoinResolver, which doesnt exist yet. We need to decide where is > the right place to populate this field. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java f1c3564 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkReduceSinkMapJoinProc.java > 92600be > > Diff: https://reviews.apache.org/r/27640/diff/ > > > Testing > ------- > > > Thanks, > > Suhas Satish > >
