> On Nov. 7, 2014, 9:51 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java, line > > 207 > > <https://reviews.apache.org/r/27745/diff/1/?file=754765#file754765line207> > > > > Don't we need this any more?
It is not used any place. > On Nov. 7, 2014, 9:51 p.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java, line > > 311 > > <https://reviews.apache.org/r/27745/diff/1/?file=754765#file754765line311> > > > > This doesn't seem resolve conflicts for files generated by different > > partitions. These partitions can run on different nodes, so fileIndex might > > be the same. One operator, many tasks because we want more reducers. You are right. That won't work. Let me fix this. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27745/#review60386 ----------------------------------------------------------- On Nov. 7, 2014, 9:34 p.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27745/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2014, 9:34 p.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8621 > https://issues.apache.org/jira/browse/HIVE-8621 > > > Repository: hive-git > > > Description > ------- > > In case spark, HashTableSinkOperator should dump files to a folder expected > by HashTableLoader. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java > f0e04e7 > > Diff: https://reviews.apache.org/r/27745/diff/ > > > Testing > ------- > > > Thanks, > > Jimmy Xiang > >
