[ https://issues.apache.org/jira/browse/HIVE-8786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203039#comment-14203039 ]
Hive QA commented on HIVE-8786: ------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12680291/HIVE-8786.1.patch {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 6671 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_acid_join org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_insert_nonacid_from_acid org.apache.hive.hcatalog.streaming.TestStreaming.testEndpointConnection org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Json {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1693/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1693/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1693/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12680291 - PreCommit-HIVE-TRUNK-Build > ObjectStore.rollbackTransaction() should decrement openTrasactionCalls and > not set it to 0 > ------------------------------------------------------------------------------------------- > > Key: HIVE-8786 > URL: https://issues.apache.org/jira/browse/HIVE-8786 > Project: Hive > Issue Type: Bug > Components: Metastore > Reporter: Hari Sankar Sivarama Subramaniyan > Assignee: Hari Sankar Sivarama Subramaniyan > Attachments: HIVE-8786.1.patch > > > In ObjectStore.java, > {noformat} > public void rollbackTransaction() { > if (openTrasactionCalls < 1) { > debugLog("rolling back transaction: no open transactions: " + > openTrasactionCalls); > return; > } > openTrasactionCalls = 0; > {noformat} > I think the above code should be changes to openTrasactionCalls--; instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)