----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27847/#review60859 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java <https://reviews.apache.org/r/27847/#comment102260> Wondering if there is any value in doing ensureDbInit() ? Seems like runTestQuery() is sufficient. If ensureDbInit() is indeed needed, can you please add comment why is it needed? - Ashutosh Chauhan On Nov. 11, 2014, 7:34 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27847/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 7:34 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cca57d2 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > b6c633c > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 758f77c > > metastore/src/java/org/apache/hadoop/hive/metastore/StatObjectConverter.java > 0f99cf3 > > Diff: https://reviews.apache.org/r/27847/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
