----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27900/#review61329 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java <https://reviews.apache.org/r/27900/#comment102897> Wondering if this method can be used to determine other DBs as well like MSSQL, ORACLE? Seems like method getDBProdName() is meant specificly for this purpose. This requires testing on other DBs, so perhaps this could be done in a follow-up jira. But, it will be good to leave a TODO here. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java <https://reviews.apache.org/r/27900/#comment102895> Better name since its not limited to Derby: stopDBFromPushingCastAboveJoin? - Ashutosh Chauhan On Nov. 13, 2014, 10:26 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27900/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 10:26 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 82f504f > > Diff: https://reviews.apache.org/r/27900/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
