Hi Makoto, Thanks, I see. Continue to putting my +1 here.
Best, Takuya 2018年2月16日(金) 12:46 Makoto Yui <yuin...@gmail.com>: > Takuya, > > The commit is to follow 4-b of Apache License 2.0: > > "You must cause any modified files to carry prominent notices > stating that You changed the files" > https://www.apache.org/licenses/LICENSE-2.0 > > It's just a comment for the notification and not a legal format. URL > is an optional one. > > Thanks, > Makoto > > > 2018-02-16 11:27 GMT+09:00 Takuya Kitazawa <tak...@apache.org>: > > Confirmed: > > > > - Pass build and all tests > > - Core update from rc2 c742ce58e94913bf446c3b296a24415676f9ac3b is surely > > available by: select tree_predict('', '', array(), '-help'); > > > > One question - Following commit adds links to external source code we > used: > > > https://github.com/apache/incubator-hivemall/commit/f51a643757d3f005ac1dc69709103cafcc6fb1a4 > , > > but is it okay to simply use URLs pointing to their master branch? IMO, > > since code in the master branch would be changed in the future, pointing > to > > specific commit ID is better to show exact dependency on third-party > code. > > > > Anyway, I guess it's a minor stuff, and there is no crucial problems for > > release. So, here I would say +1. > > > > Best, > > Takuya > > > > 2018年2月16日(金) 7:37 Takeshi Yamamuro <linguin....@gmail.com>: > > > >> Hi, > >> > >> +1 > >> > >> I checked the candidate on the same ec2 instance again; > >> all the tests were passed and all the verification was ok. > >> > >> Thanks, > >> takeshi > >> > >> On Wed, Feb 14, 2018 at 7:33 PM, yuming wang <wgy...@gmail.com> wrote: > >> > >>> +1 > >>> > >>> > >>> On 02/14/2018 15:56, Makoto Yui <m...@apache.org> wrote: > >>> > >>> Hi all, > >>> > >>> Apache Hivmeall 0.5.0 release candidate #3 is now available for a vote > >>> within dev community. > >>> > >>> Links to various release artifacts are given below. Please review and > >>> cast your vote. > >>> > >>> - The source tarball, including signatures, digests, ChangeLog, > etc.: > >>> > >>> > https://dist.apache.org/repos/dist/dev/incubator/hivemall/0.5.0-incubating-rc3/ > >>> - Sources for the release: > >>> > >>> > https://dist.apache.org/repos/dist/dev/incubator/hivemall/0.5.0-incubating-rc3/hivemall-0.5.0-incubating-source-release.zip > >>> > >>> > https://dist.apache.org/repos/dist/dev/incubator/hivemall/0.5.0-incubating-rc3/hivemall-0.5.0-incubating-source-release.zip.asc > >>> (PGP Signature) > >>> > >>> > https://dist.apache.org/repos/dist/dev/incubator/hivemall/0.5.0-incubating-rc3/hivemall-0.5.0-incubating-source-release.zip.md5 > >>> (MD5 Hash) > >>> - Git tag for the release: > >>> > >>> > https://git-wip-us.apache.org/repos/asf?p=incubator-hivemall.git;a=shortlog;h=refs/tags/v0.5.0-rc3 > >>> - The Nexus Staging URL: > >>> > >>> > https://repository.apache.org/content/repositories/orgapachehivemall-1003/ > >>> - KEYS file for verification: > >>> https://dist.apache.org/repos/dist/dev/incubator/hivemall/KEYS > >>> - For information about the contents of this release, see: > >>> > >>> > https://dist.apache.org/repos/dist/dev/incubator/hivemall/0.5.0-incubating-rc3/ChangeLog.html > >>> > >>> Find Podling releases policies in > >>> https://incubator.apache.org/policy/incubation.html#releases > >>> http://www.apache.org/legal/release-policy.html > >>> > >>> Artifacts verification how-to can be found in > >>> http://hivemall.incubator.apache.org/verify_artifacts.html > >>> > >>> The vote will be open for at least 72 hours and until necessary number > >>> of votes are reached. > >>> > >>> At lease three +1 from PPMC members are required and we welcome your > >>> vote! > >>> Particularly, we expect votes from PPMC members and Committers. > >>> > >>> [ ] +1 approve (Release this package as Apache Hivemall > >>> 0.5.0-incubating) > >>> [ ] +0 no opinion > >>> [ ] -1 disapprove (and reason why) > >>> > >>> Here is my +1 (binding). > >>> > >>> Regards, > >>> Makoto > >>> > >>> -- > >>> Makoto YUI <myui AT apache.org> > >>> Research Engineer, Treasure Data, Inc. > >>> http://myui.github.io/ > >>> > >>> > >> > >> > >> -- > >> --- > >> Takeshi Yamamuro > >> >
