nadment edited a comment on pull request #451: URL: https://github.com/apache/incubator-hop/pull/451#issuecomment-741318808
1) Some renaming "space" to "variables" is not good > @return the amount of free swap **variables** in bytes > when pressing ctrl+**variables** 2) Is it possible to have a clean API? String environmentSubstitute( String string ) >>> String resolve( String string ); String[] environmentSubstitute( String[] string ) >>> String[] resolve( String[] string ); public String fieldSubstitute( String string, IRowMeta rowMeta, Object[] rowData ) throws HopValueException >>> public String resolve( String string, IRowMeta rowMeta, Object[] rowData ) throws HopValueException boolean getBooleanValueOfVariable( String name, boolean defaultValue ) >>> boolean getVariableBoolean( String name, boolean defaultValue ) String[] listVariables() >>> String[] getVariableNames(); IVariables getParentVariableSpace() >>> IVariables getParentVariables() void setParentVariableSpace( IVariables parent ) >>> void setParentVariables( IVariables parent ) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
