[GitHub] [incubator-hop] usbrandon commented on pull request #465: HOP-2296 Fix HopVfsFileDialog optimal column width

[GitBox]

usbrandon commented on pull request #465:
URL: https://github.com/apache/incubator-hop/pull/465#issuecomment-744034369


   Opening the file dialog worked and the column widths looked good.  However, 
I got an NPE when double clicking on a folder.  
   Windows 10.  -- In the current master build of hop before your Pull Request, 
There is a SWT exception and it also fails.
   
   It gave the following stack trace:
   Error browsing to location: C:\Users\usbra\Box
   NullPointerException: 
   Root cause: NullPointerException: 
   
   java.lang.NullPointerException
        at org.eclipse.swt.widgets.TreeItem.getBounds(TreeItem.java:419)
        at org.eclipse.swt.widgets.TreeColumn.pack(TreeColumn.java:371)
        at 
org.apache.hop.ui.core.widget.TreeUtil.setOptimalWidthOnColumns(TreeUtil.java:29)
        at 
org.apache.hop.ui.core.vfs.HopVfsFileDialog.resizeTableColumn(HopVfsFileDialog.java:1211)
        at 
org.apache.hop.ui.core.vfs.HopVfsFileDialog.lambda$open$7(HopVfsFileDialog.java:465)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
        at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4105)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1037)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1061)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1042)
        at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5768)
        at org.eclipse.swt.widgets.Display.windowProc(Display.java:4749)
        at org.eclipse.swt.internal.win32.OS.DefWindowProc(Native Method)
        at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1454)
        at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5830)
        at org.eclipse.swt.widgets.Display.windowProc(Display.java:4749)
        at org.eclipse.swt.internal.win32.OS.SetScrollInfo(Native Method)
        at org.eclipse.swt.widgets.Tree.updateScrollBar(Tree.java:5650)
        at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1601)
        at org.eclipse.swt.widgets.Scrollable.WM_SIZE(Scrollable.java:348)
        at org.eclipse.swt.widgets.Composite.WM_SIZE(Composite.java:1714)
        at org.eclipse.swt.widgets.Tree.WM_SIZE(Tree.java:7071)
        at org.eclipse.swt.widgets.Control.windowProc(Control.java:4795)
        at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5929)
        at org.eclipse.swt.widgets.Display.windowProc(Display.java:4749)
        at org.eclipse.swt.internal.win32.OS.CallWindowProc(Native Method)
        at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1546)
        at 
org.eclipse.swt.widgets.Control.WM_WINDOWPOSCHANGED(Control.java:5644)
        at org.eclipse.swt.widgets.Control.windowProc(Control.java:4808)
        at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5929)
        at org.eclipse.swt.widgets.Display.windowProc(Display.java:4749)
        at org.eclipse.swt.internal.win32.OS.CallWindowProc(Native Method)
        at org.eclipse.swt.widgets.Tree.callWindowProc(Tree.java:1546)
        at org.eclipse.swt.widgets.Control.windowProc(Control.java:4819)
        at org.eclipse.swt.widgets.Tree.windowProc(Tree.java:5929)
        at org.eclipse.swt.widgets.Display.windowProc(Display.java:4757)
        at org.eclipse.swt.internal.win32.OS.SendMessage(Native Method)
        at org.eclipse.swt.widgets.Tree.removeAll(Tree.java:3933)
        at 
org.apache.hop.ui.core.vfs.HopVfsFileDialog.refreshBrowser(HopVfsFileDialog.java:761)
        at 
org.apache.hop.ui.core.vfs.HopVfsFileDialog.navigateTo(HopVfsFileDialog.java:1068)
        at 
org.apache.hop.ui.core.vfs.HopVfsFileDialog.fileDefaultSelected(HopVfsFileDialog.java:692)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
        at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4105)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1037)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3922)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3524)
        at 
org.apache.hop.ui.core.vfs.HopVfsFileDialog.open(HopVfsFileDialog.java:520)
        at 
org.apache.hop.ui.core.dialog.BaseDialog.presentFileDialog(BaseDialog.java:192)
        at 
org.apache.hop.ui.core.dialog.BaseDialog.presentFileDialog(BaseDialog.java:97)
        at 
org.apache.hop.ui.hopgui.delegates.HopGuiFileDelegate.fileOpen(HopGuiFileDelegate.java:66)
        at org.apache.hop.ui.hopgui.HopGui.menuFileOpen(HopGui.java:530)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.apache.hop.ui.core.gui.BaseGuiWidgets.lambda$getListener$1(BaseGuiWidgets.java:145)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
        at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4105)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1037)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3922)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3524)
        at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:363)
        at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:299)
   
   
![image](https://user-images.githubusercontent.com/1233654/102017946-8cce0000-3d2f-11eb-8283-47ac9ff76dd2.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org